Skip to content

workflow identifiers and warning/error views #405

Open

Description

@marcverhagen

We have this helper function:

def generate_workflow_identifier(mmif_input: Union[str, Path, Mmif],
return_param_dicts: bool = False
) -> Union[str, Tuple[str, List[dict]]]:

The docstring of it states:

Views with errors or warnings are excluded from the identifier; empty views are included

I wonder why warning and error views are excluded.

In my case, I am using this helper function in mmif-storage in upload_mmif(). My test file has three views, two by a dummy application and one a warning view from SWT. When stored I would like that filed under "/" and not under "", which is where it ends up now.

So I would like the warning and error views included. If there is a good reason to exclude them then we could introduce a parameter to include them (with the default set to not-include).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status
      Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions