Skip to content

fix VDH's (un-)handling of incomplete video container metadata - #391

Merged
keighrim merged 2 commits into
developfrom
390-fix-framecount-zeroing
Jun 19, 2026
Merged

keighrim merged 2 commits into
developfrom
390-fix-framecount-zeroing

Conversation

@keighrim

Copy link
Copy Markdown
Member

fixes #390

keighrim added 2 commits June 18, 2026 10:45
stream metadata is incomplete to get basic technical information. This happened with matroska container file.
@clams-bot clams-bot added this to infra Jun 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in infra Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.81%. Comparing base (21ca1e0) to head (3428ebf).

Files with missing lines Patch % Lines
mmif/utils/video_document_helper.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #391      +/-   ##
===========================================
+ Coverage    74.78%   74.81%   +0.03%     
===========================================
  Files           27       27              
  Lines         3228     3240      +12     
===========================================
+ Hits          2414     2424      +10     
- Misses         814      816       +2     
Flag Coverage Δ
unittests 74.81% <95.83%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keighrim
keighrim merged commit d155765 into develop Jun 19, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in infra Jun 19, 2026
@keighrim
keighrim deleted the 390-fix-framecount-zeroing branch July 6, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Some Matroska/webm videos yield zero extracted frames (empty output / 500)

2 participants