fix: keep cache and form changesets on a minor release - #225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Original request
Keep the recent Framework cache/form work on a minor release rather than a major release, and open a new PR before continuing Xpenser.
What changed
.changeset/cache-form-correctness.mdfrommajortominor; react-form remainsminor..changeset/defaulted-form-fields.mdfrompatchtominor, consistent with this batch and its new public type exports.Reasoning
A major entry in the fixed release group schedules all 19 Framework packages for 5.0.0. The corrected release plan schedules all 19 for 4.5.0, with no major releases. This changes the classification of this batch, not the general policy for future breaking changes.
The existing cache-key format and
deepEqualbehavior changes still require the documented consumer review/migration; relabeling the release does not make those compatibility concerns disappear.Type of change
Blog post
Skipped: internal release metadata, not a new user-facing feature.
Screenshots / preview evidence
Not applicable: no UI or runtime change. Framework CI has no PR preview deployment; the generated release plan is the relevant evidence.
Validation / Checklist
npm ci --ignore-scriptsnpm run lintnpm run buildnpm test— 4,267 tests across 178 files; no type errorsnpm run typecheck:schema-sitenpm run typecheck:docs-sitenpm run changeset -- status --output <temporary plan.json>, with assertions that all 19 fixed-group packages are minor releases at 4.5.0 and that the complete plan has no major releasegit diff --checkNo packages versioned/published and no PR merged.