Repository navigation
fix: preserve property definitions and documentation across derived types - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go to Definition on
query(knex, UserSchema).where(t => t.firstName, 'John')previously returned no definition, although the equivalent
getErrorsForselector navigated to the schema. Several derived property types also lost
their original hover documentation.
Preserve property origins through mapped types and relation metadata. This
restores navigation and JSDoc for query selectors, decoded rows, projections,
write payloads, relation includes, mapper targets, JSON Schema inferred values,
composed API groups, injected services, and shared deep-merge properties.
Renamed projection results navigate to the projection declaration. Existing
property types, filtering, modifiers, merge precedence, and runtime behavior
are preserved.
The new language-service suite exercises the published declarations from
TypeScript and checked JavaScript, including imported schemas and existing
working schema, form, and client APIs. It also checks compatibility for indexed
sources, optional/readonly fields, relation filtering, and mapping completeness.
TypeScript still omits hover JSDoc on some union-context update object literals;
Go to Definition is covered and works for those properties.
Type of Change
Validation
npm run lint— passed.npm run build— passed, all 24 build tasks.npm run test— passed, 4,717 tests across 233 test files; no type errors.npm run typecheck:schema-site— passed.npm run typecheck:docs-site— passed.Checklist
npm run lintand fixed any issuesnpm run testand all tests passnpx changeset) if this changes package behavior