fix(dev): keep server-resolved packages out of every dep optimizer - #3235
Open
JamesbbBriz wants to merge 4 commits into
Open
JamesbbBriz wants to merge 4 commits into
JamesbbBriz wants to merge 4 commits into
Conversation
Two gaps let node-shaped packages break the dev server when they were reached through server code: - file-type ships a dual CJS/ESM package. When any optimizer pre-bundles it (Payload reaches it through payload/dist/uploads), Rolldown resolves the core entry and loses the named exports — MISSING_EXPORT on fileTypeFromFile and friends, and the dev server dies. The runtime resolvers load it fine, so it now joins the shared exclude list. - server-external packages were excluded from the client optimizer but not from the rsc/ssr optimizers, even though the server environments already load them through the runtime resolver. Their node-only conditional exports resolve to the wrong entry inside the optimizer pipeline, so the rsc and ssr excludes now mirror the client one. The app-router dev-server regression surface is covered by asserting all three optimizers exclude both the server-external entries and file-type.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
Posted 1 actionable inline review finding. Targeted tests pass. |
Member
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps let Node-oriented packages break the dev server when reached through server code:
file-typeuses conditional exports: its Node entry exposes APIs such asfileTypeFromFile, while its defaultcore.jsentry does not. When the dependency optimizer reaches it through packages such as Payload, Rolldown can selectcore.jsand fail withMISSING_EXPORT. Runtime resolution selects the correct entry, sofile-typeis now excluded from pre-bundling.serverExternalPackagesare runtime-resolved, but were not excluded consistently from dependency optimization. App Router RSC/SSR/client optimizers and Pages Router client/SSR/Cloudflare Worker optimizers now all preserve that invariant.Regression coverage checks both App and Pages Router optimizer configurations, including the Cloudflare Pages Router Worker environment. This follows Next.js's coverage of
serverExternalPackagesin both App and Pages Router applications.Validation:
vp test run tests/build-optimization.test.ts— 170 passed, 2 skippedvp check packages/vinext/src/index.ts packages/vinext/src/plugins/rsc-client-shim-excludes.ts tests/build-optimization.test.tsvp run vinext#buildFixes #3236