feat(ENG-13667): adding betterleaks checks to pre-commit hooks and CI - #359
Closed
coillteoir wants to merge 1 commit into
Closed
feat(ENG-13667): adding betterleaks checks to pre-commit hooks and CI#359coillteoir wants to merge 1 commit into
coillteoir wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: dortort/betterleaks-action@v0.1.0 |
Comment on lines
+15
to
+17
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds secret scanning via Betterleaks and tidies the existing pre-commit YAML formatting to strengthen automated checks in local dev and CI.
Changes:
- Reformats
.pre-commit-config.yamlfor consistent YAML indentation and adds thebetterleakspre-commit hook. - Adds a GitHub Actions workflow to run Betterleaks on pushes and pull requests.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Re-indents existing hooks and adds Betterleaks to run locally via pre-commit. |
.github/workflows/betterleaks.yaml |
Introduces CI workflow to run Betterleaks in GitHub Actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+4
to
+22
| branches: | ||
| - master | ||
| pull_request: | ||
| branches: | ||
| - "**" | ||
| jobs: | ||
| betterleaks: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: dortort/betterleaks-action@v0.1.0 | ||
| id: betterleaks | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: dortort/betterleaks-action@v0.1.0 |
| hooks: | ||
| - id: pyupgrade | ||
| args: [--py310-plus] | ||
| .bumpversion.cfg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.