feat(ENG-13667): adding betterleaks checks to pre-commit hooks and CI - #360
Open
coillteoir wants to merge 1 commit into
Open
feat(ENG-13667): adding betterleaks checks to pre-commit hooks and CI#360coillteoir wants to merge 1 commit into
coillteoir wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Betterleaks secret-scanning to the repo via both pre-commit and a GitHub Actions workflow to catch credential leaks earlier and in CI.
Changes:
- Reformat
.pre-commit-config.yamlfor consistent YAML indentation and add thebetterleakspre-commit hook. - Add a new GitHub Actions workflow to run Betterleaks on pushes and pull requests.
- Upload Betterleaks scan output as a CI artifact.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Reformats hook configuration and adds Betterleaks to local developer workflows. |
| .github/workflows/betterleaks.yaml | Introduces CI secret scanning with artifact upload for scan reports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| on: | ||
| push: | ||
| branches: | ||
| - master |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: dortort/betterleaks-action@v0.1.0 |
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| if: always() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Additional Notes