Repository navigation
refactor(rules): drop the pre-1.5.0 coco archive naming - #265
Open
GPLeemrijse wants to merge 1 commit into
Open
GPLeemrijse wants to merge 1 commit into
GPLeemrijse wants to merge 1 commit into
Conversation
Popili 1.5.0 is the minimum supported version, so toolchain archives and binaries are always named popili. Also list the newer version first in the coco.toolchain versions example.
GPLeemrijse
marked this pull request as ready for review
November 6, 2026 12:58
tomgr
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popili 1.5.0 is the minimum supported version, so the toolchain archive and binary are always named
popili: this removes_product_for(which pickedcocofor versions before 1.5) and the now-constantproductparameter ofBUILD_for_coco_archive. Thecoco.toolchainversions example no longer names 1.4.0 and lists the newer version first._determine_product_nameis taken care of in #260Tested: lint, Starlark unit tests, root integration and all e2e scenarios (bzlmod).