Repository navigation
Limit CelesTrak cooldowns to rate limits and service failures - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #67.
PR #66 made every non-200 CelesTrak response start a service-wide cooldown. This narrows that to the agreed cases:
Cached results remain usable during either pause. Recognized temporary 403 handling and the read-only cache repair from PR #66 are unchanged.
Evidence
OPENBLAS_NUM_THREADS=1 OMP_NUM_THREADS=1 apps/mcp-server/.venv312/bin/python -m pytest -q apps/mcp-server/testsin 122.91 seconds. Two existing dependency deprecation warnings remain.Merge Danger
Door: two-way.
Reverting restores the broader non-200 pause from PR #66. Merging to main follows the existing MCP image build and EC2 deployment workflow.
Blast Radius: CelesTrak.
A generic 403, 3xx, or other 4xx now stops only the current lookup. The next lookup may contact CelesTrak again, which the usage policy asks clients to avoid; the app reports the status and cause so the caller can stop.