Skip to content

Limit CelesTrak cooldowns to rate limits and service failures - #68

Merged
satyalyadav merged 1 commit into
mainfrom
fix/celestrak-cooldown-scope
Nov 7, 2026
Merged

satyalyadav merged 1 commit into
mainfrom
fix/celestrak-cooldown-scope

Conversation

@satyalyadav

Copy link
Copy Markdown
Collaborator

Summary

Closes #67.

PR #66 made every non-200 CelesTrak response start a service-wide cooldown. This narrows that to the agreed cases:

  • HTTP 429 and CelesTrak's explicit temporary-rate-limit HTTP 403: two-hour pause.
  • HTTP 5xx: ten-minute pause.
  • Every other non-200 response, including a generic 403, 3xx, 400, 401, and 404: explanatory app error, no service-wide pause.

Cached results remain usable during either pause. Recognized temporary 403 handling and the read-only cache repair from PR #66 are unchanged.

Evidence

  • 552 tests passed on Python 3.12.3 using OPENBLAS_NUM_THREADS=1 OMP_NUM_THREADS=1 apps/mcp-server/.venv312/bin/python -m pytest -q apps/mcp-server/tests in 122.91 seconds. Two existing dependency deprecation warnings remain.
  • Focused cache tests: 56 passed.
  • The HTTP failure table now covers 429, recognized 403, generic 403, 5xx, 301, and 404 with the expected pause state.
  • No live CelesTrak requests were made.

Merge Danger

Door: two-way.

Reverting restores the broader non-200 pause from PR #66. Merging to main follows the existing MCP image build and EC2 deployment workflow.

Blast Radius: CelesTrak.

A generic 403, 3xx, or other 4xx now stops only the current lookup. The next lookup may contact CelesTrak again, which the usage policy asks clients to avoid; the app reports the status and cause so the caller can stop.

@satyalyadav
satyalyadav merged commit 23caad9 into main Nov 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit CelesTrak service-wide cooldowns to 429 and 5xx

1 participant