Repository navigation
Draw instrument footprints and sampled trails in the Cesium Study pane - #72
Open
darthvader58 wants to merge 2 commits into
Open
darthvader58 wants to merge 2 commits into
darthvader58 wants to merge 2 commits into
Conversation
This was referenced Nov 17, 2026
darthvader58
marked this pull request as ready for review
November 17, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument footprints in the Study pane now come from native TAT-C
collect_ground_trackfor supplied basic, pointed and conical instruments. Conical-only studies draw the actual scan band or sector instead of showing only the satellite track. Polygon holes and multipart/antimeridian boundaries are preserved, and invalid samples are hidden according to TAT-C's footprint-centervalid_obscheck.An optional Sampled footprint trail draws past valid sample polygons within the shared trail duration. All footprints use the nearest native display sample to avoid morphing vertex topology at poles and the antimeridian. Sampled footprints do not establish continuous viewing duration or a dissolved observed area. Point-event accounting is unchanged, and the existing sample budget now covers every instrument.
The legacy inline MapLibre tool is unchanged in this PR. Native
compute_ground_trackdissolved-area support and migration into the Study pane are tracked separately in #70. The capability inventory now corrects its previous attribution of the legacy map to that native function.Closes #71
Closes #69
Validation:
git diff --checkpassed.--comparecompleted. Both the prior run and this run scored 19% with two infrastructure failures. Recorded CelesTrak responses fail in the cache streaming path (Response.rawisNone), so these runs do not provide a clean model-behavior baseline; keep this PR draft until that independent eval harness problem is resolved and the comparison rerun. Streaming probe passed.Polar rendering is also corrected here: wide native polygons are partitioned for Cesium, true TAT-C boundary arcs omit artificial seams, and native precision/holes are retained. This shares the geometry helper and 19 native polar/antimeridian tessellation regressions with the small stacked follow-up darthvader58#1 (for migration PR #74). No MapLibre migration code is included in this PR.