Repository navigation
Add EarthCARE and TRMM instruments to the catalog - #160
Merged
Merged
Conversation
…the catalog TMI, VIRS, and EarthCARE MSI are validated on data held out 39 to 41 days from the fit. TRMM PR is partial, as its published footprint at the scan's edge (5.0 km) lies 7.9% below the size its beam gives, while its swath is validated. ATLID and CPR, of a new profiler class (version 6 of the standard, with the altimeter's gates), are partial on track offset (0.72 km) with the element set nearest the held-out day's middle; the day's other set passes, stated in their limitations and not counted. BBR is partial on pass recall and, with that set, swath IoU; it is scored with breaks in its data over 1 s as periods without data, chosen after a first score on the day of the fit, and stated in its limitations. EarthCARE product times include leap seconds and are corrected to UTC. observe_orbit bounds its nearest-neighbor query, which gives the same cells compared in minutes rather than hours. Its span of the day is documented as it is: TAT-C's mean motion, in degrees per second, is read as revolutions per day, so swath IoU compares from noon to the end of the day rather than one orbit, for every record scored through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
earthcare_msi, asmsiis Sentinel-2), and TRMM PR, TMI, and VIRS. Each was fitted on one day and tested on data held out 39 to 41 days later; both days were fixed before any result.profilerclass, for ATLID and CPR, with the altimeter's gates (segment recall and track offset). No earlier threshold changes, and earlier versions remain compatible.docs/validation/validate_catalog_{atlid,bbr,cpr,earthcare_msi,tmi,trmm_pr,virs}.py, with the shared readerearthcare_io.py) and the element set files they read. EarthCARE product times include leap seconds and are corrected to UTC.gesdisc_scanner.observe_orbitnow bounds its nearest-neighbor query. The cells compared are the same (checked on a sample), and the search takes about a minute rather than hours.observe_orbitreads TAT-C's mean motion (deg/s) as revolutions per day, so swath IoU compares a span from noon to the end of the day rather than one orbit. This applies to every record scored through it, about 15 existing entries and the new ones. The code is unchanged here; its docstrings describe the span.docs/validation/summary.rst, and a CHANGELOG entry.Checks: the full unit test suite passes (one skip that was already there), black is clean, and pylint rates
src/tatc/catalog9.95. The catalog page generates with all seven entries. I have not built the full documentation.