feat(tokens): revamped v2 currency-info layout - #1247
Open
bmc08gt wants to merge 1 commit into
Open
Conversation
Ports the iOS currency-info revamp (code-ios-app#585) to Android's new UI. Gated on FeatureFlag.NewUi; the legacy token-info screen is untouched for the old UI. New CurrencyInfoContentV2 (LazyColumn), top -> bottom: - Hero bill card (reuses TokenCard) - balance + appreciation when held, identity only when not - Action tiles - Give / Convert / Withdraw, single Get when not held; USDF is Convert + Withdraw (no Give - ships separately, per iOS) - Recent - per-token activity preview (reuses ActivityFeedRow), held only - Market Cap + chart (reuses MarketCapSection), non-USDF - About - description (ExpandableText) + social chips - Created-at footer, non-USDF - Scroll-revealed leading title pill (icon + name + market cap), fades in on scroll The screen hosts its app bar as the CodeScaffold topBar and does not apply the top inset, so content scrolls under the bar with the app-standard soft top fade. Actions reuse existing pushes (Give sheet, Swap-buy, Withdrawal) - no buy-flow plumbing needed (already pushable on Android). Data: adds a bounded per-token recent-activity query - MessageDao.observeRecentForMint, MessageDataSource.observeRecent(mint, limit), ActivityFeedCoordinator.recentTransactions(mint, limit) - surfaced as TokenInfoViewModel.State.transactions (read off IO so the page arrives in one pass). All sizing/type via grid/staticGrid/typography/shape/color tokens (rescales when the grid moves to 4pt).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the iOS currency-info revamp (code-ios-app#585) to Android's new UI. Gated on
FeatureFlag.NewUi; the legacy token-info screen is untouched for the old UI. PR 1 of the two-part port (this is the layout; the Apple-Wallet card-expand animation is the follow-up).New
CurrencyInfoContentV2(LazyColumn), top → bottom — all reusing existing components:TokenCard) — balance + appreciation when held, identity only when notActivityFeedRow), held onlyMarketCapSection), non-USDFExpandableText) + social chipsThe screen hosts its app bar as the
CodeScaffoldtopBar and does not apply the top inset, so content scrolls under the bar with a short soft top fade. Actions reuse existing pushes (Give sheet, Swap-buy, Withdrawal) — no buy-flow plumbing needed (buy is already pushable on Android, unlike iOS).Data: adds a bounded per-token recent-activity query —
MessageDao.observeRecentForMint,MessageDataSource.observeRecent(mint, limit),ActivityFeedCoordinator.recentTransactions(mint, limit)— surfaced asTokenInfoViewModel.State.transactions(read off IO so the page arrives in one pass).All sizing/type via grid/staticGrid/typography/shape/color tokens, so it rescales when the grid moves to 4pt.
Verified on device (emulator)
Deliberate deviations from the Figma (following the iOS PR decisions)