Repository navigation
fix(viewer): keep pull-to-refresh out of scroll regions - #118
Merged
Merged
Conversation
On Android, scrolling a list or a terminal up to its top handed the rest of the gesture to the document, and the browser reloaded the viewer. Scroll regions now contain vertical overscroll; fixed bars such as the header still reach the document, so a deliberate pull still refreshes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9Y6nr4J3kMp6GVQNUd9Ry
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
On a Galaxy Fold (Android Chrome / Samsung Internet), scrolling the viewer's content up to its top kept reloading the page: once a scroll region reached its top, the rest of the pull went to the document and triggered pull-to-refresh. iOS has no such gesture, so it only showed on Android.
Change
overscroll-behavior-y: containon the scroll regions (.overflow-auto,.overflow-y-auto,.xterm-viewport), so it also covers regions added later.docs/web-viewer.mdmobile paragraph.Verification
npm test936 passed,tsc -bok,npm run build; the rule is present in the built CSS and baseline dist reproduces cleanly. Pre-push hook passed.NODE_OPTIONS=--experimental-strip-types(the newcheck-deps.tsprebuild needs it; CI uses Node 26).🤖 Generated with Claude Code
https://claude.ai/code/session_01K9Y6nr4J3kMp6GVQNUd9Ry