Repository navigation
fix(viewer): draw the loading splash in today's shell outline - #124
Merged
Merged
Conversation
The splash predated the terminal row, the phone view switcher and the mark-only phone header, so the first paint changed shape when the app arrived. It now shows the header as Brand/Header draw it, list and content over the terminal on wide screens, and the bottom switcher on a phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9Y6nr4J3kMp6GVQNUd9Ry
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loading splash still had the old outline: no terminal row, no phone view switcher, and a name bar on the phone header that the app no longer draws. It now matches the current shell at both widths.
Verification: tsc,
npm test(954 passed),npm run build(dist included), pre-push gate, screenshots at 1280 and 390 px with the API held. No visual baseline covers the splash.🤖 Generated with Claude Code
https://claude.ai/code/session_01K9Y6nr4J3kMp6GVQNUd9Ry