Fix tfsec demo frame in PDF and printed slides - #38
Merged
Merged
Conversation
… ci] Preserve Marp 3.0.2 and all talk material while adding PDF publishing and fixing agenda overflow. Skip unrelated PR security scanners for this documentation-only rollout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the animated HTML demo and use an extracted results frame for PDF and print output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tfsec Results22 tests 9 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 16a3157. |
checkov Results7 tests 7 ✅ 0s ⏱️ Results for commit 16a3157. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Deck review
DECK REVIEW COMPLETE with documented source-image limitations. Full HTML/PDF rendered with publisher-version Marp 3.0.2; structural overflow check found zero overflows. Previous 32/32-slide visual review is retained; newly rendered PDF slide 16 was inspected, and all other 31 PDF pages are pixel-identical to the reviewed version. All 32 PDF pages have unchanged extracted text. Browser checks confirm the HTML GIF remains active, the print PNG loads, only the tfsec background changes between screen and print, and no requests failed.
Remaining source-image limitations: small/clipped screenshot details on slides 7, 8, 17, 18, 19 and 23; slide 16 still has small terminal text at half-slide width. No missing raster text was invented. The GIF was sampled, not reviewed frame by frame.
Follows merged #37. Normal repository CI is enabled without suppression. Existing main-push Pages publishing remains unchanged; the updated public PDF awaits merge and the normal Pages run. No manual scanners, Terraform, deployment, or merge was performed.