Fix false TT hits for zero verification keys - #1128
Draft
kuel27 wants to merge 1 commit into
Draft
Conversation
When a TT slot is cleared, it has a verification key zero, but zero is also a valid 21-bit verification key. So a probe with this key can match an unused slot and read zeroed data as a valid TT entry. To fix this, reserve verification key zero for unused slots. Skip TT reads and writes for positions with this key. Bench: 2957947
Contributor
|
Should fix that by using some other mechanism to determine tthits than keys, usually people reserve internal entry depth of 0 to refer to no entry but that has some complications in Reckless where a real entry could also have that depth.. I don’t think this version of the PR will do. |
kuel27
marked this pull request as draft
August 29, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TT slot is cleared, it has a verification key of zero, but zero is also a valid 21-bit verification key. So a probe with this key can match an unused slot and read zeroed data as a valid TT entry.
This reproduces the bug:
The assertion fails before this patch and passes after it. Fixing the false hit changes the standard bench from 2985186 to 2957947 nodes.
To fix this, reserve verification key zero for unused slots. Skip TT reads and writes for positions with this key.
Bench: 2957947