fix: surface codefresh-run CLI failures instead of bare exit 1 [closes CCS-20] - #738
Draft
openswe-task-force[bot] wants to merge 1 commit into
Draft
fix: surface codefresh-run CLI failures instead of bare exit 1 [closes CCS-20]#738openswe-task-force[bot] wants to merge 1 commit into
openswe-task-force[bot] wants to merge 1 commit into
Conversation
…s CCS-20] The step template captured the CLI output and exited silently, so every failure of the typed step surfaced only as "plugin failed" with no diagnostics. Echo the captured output, propagate the CLI exit code, and explain the empty-build-id case. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
codefresh-runstep template captured the CLI output into a variable and then exited silently when no build id came back, so every failure surfaced only as "plugin failed" with no diagnostics (reported by yellowbrickdata when the step is gated on a terminalworkflow.resultand the build is terminated gracefully). The template now captures stderr too, echoes the captured output, propagates the CLI's exit code, and prints an explicit message for the "succeeded but no build id" case.metadata.versionbumped 1.6.0 → 1.6.1. This does not change the underlying engine behaviour for typed steps started during termination teardown — it makes the failure diagnosable.Linear ticket: https://linear.app/octopus/issue/CCS-20/yellowbrickdata-parallel-codefresh-run-step-fails-ambiguously-when
Release Note
codefresh-runnow reports the Codefresh CLI's output and exit code instead of failing with an unexplained "plugin failed".Test Plan
type: codefresh-runagainst a non-existentPIPELINE_ID; the step log shows the CLI error and the CLI's exit code.mode: parallelYAML and terminate the build during the sleep step; the step log now explains that no build id was returned.codefresh-run(bothDETACH: trueandfalse) and confirmBUILD_ID/first_CF_OUTPUT_URLare still exported correctly.Made by Open SWE