Enrich six showcase demos to match VueForge's actual frozen rendering - #21
Merged
Merged
Conversation
You said components looked worse than VueForge's fd79369 commit, which you remembered as 10/10. Checked against the real evidence rather than guessing: this repo keeps genuine frozen screenshots from that exact commit at visual-baselines/vueforge-cross-platform/, and the `visual` CI job already pixel-diffs the live Vue and Razor adapters against them on every run (currently green, 4-level-per-channel tolerance). That means the design system itself -- tokens, CSS -- is already proven pixel-faithful for every case that baseline covers. Compared six of those baseline images against the showcase demos directly and found the gap: mine were bare-bones, using each component's minimum viable props instead of the fuller composition the baseline actually shows. - Alert: baseline (alert-danger-icon) has a tone-matching icon in the icon slot; mine had none. Added CmIcon (infoCircle / alertCircle) and matched the baseline's own copy ("Submission failed" / "Review the failed fields.") for the danger case specifically. - Badge: baseline (badge-danger) shows a text label ("Blocked"), not a single digit or punctuation mark. Badge's own CSS is a text pill, not a numeral dot -- changed "3"/"!" to "New"/"Blocked". - Field: baseline (field-help-error) shows a required field with both a description and an error rendered at once. Rewrote the demo to `required`, with an error, matching the baseline's copy ("Display name" / "Shown to other members." / "Enter a display name.") exactly. - Input: baseline (input-enhanced) combines a leading slot, password-reveal, clearable, and a required indicator in one control. Added a second CmInput demonstrating all four together, including the literal "required" trailing-slot text the baseline itself displays. - Select: baseline (select-clearable) shows the clear button; mine omitted `clearable`. Added it. - Date picker: baseline (date-picker-clearable) shows a filled value with both the calendar and clear icons visible; mine was empty, showing only the calendar icon. Gave it an initial value. Verified live over CDP against the actual dev server, not just by reading the diff: confirmed the alert icon, badge text, field's required marker/description/error, input's leading/trailing/ password/clear elements, select's clear button, and the date picker's filled value all render, then screenshotted each section and compared side by side with its baseline image. Zero console warnings. No design-system code changed -- this is a demo-content fix, not a token or CSS fix. The other 38 sections weren't touched; they don't have a frozen baseline to compare against, so there was nothing concrete to check them against here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
You said components looked worse than VueForge's
fd793696commit, which you remembered as 10/10.Checked against real evidence rather than guessing: this repo keeps genuine frozen screenshots from that exact commit at
visual-baselines/vueforge-cross-platform/, and thevisualCI job already pixel-diffs the live Vue and Razor adapters against them on every run (currently green, 4-level-per-channel tolerance). That means the design system itself — tokens, CSS — is already proven pixel-faithful for every case that baseline covers.Compared six of those baseline images against the showcase demos directly and found the actual gap: mine were bare-bones, using each component's minimum viable props instead of the fuller composition the baseline shows.
What changed
alert-danger-icon) has a tone-matching icon in the icon slot; mine had none. AddedCmIcon(infoCircle/alertCircle) and matched the baseline's own copy ("Submission failed" / "Review the failed fields.") for the danger case.badge-danger) shows a text label ("Blocked"), not a digit or punctuation mark. Badge's own CSS is a text pill, not a numeral dot — changed"3"/"!"to"New"/"Blocked".field-help-error) shows a required field with both a description and an error rendered at once. Rewrote the demo torequired, with an error, matching the baseline's copy exactly ("Display name" / "Shown to other members." / "Enter a display name.").input-enhanced) combines a leading slot, password-reveal, clearable, and a required indicator in one control. Added a secondCmInputdemonstrating all four together, including the literal "required" trailing-slot text the baseline itself displays.select-clearable) shows the clear button; mine omittedclearable. Added it.date-picker-clearable) shows a filled value with both the calendar and clear icons visible; mine was empty, showing only the calendar icon. Gave it an initial value.Verified against the real thing
Drove the live dev server over the Chrome DevTools protocol: confirmed the alert icon, badge text, field's required marker/description/error, input's leading/trailing/password/clear elements, select's clear button, and the date picker's filled value all render — then screenshotted each section and compared side by side with its baseline image. Zero console warnings.
No design-system code changed — this is a demo-content fix, not a token or CSS fix. The other 38 sections weren't touched; they have no frozen baseline to compare against, so there was nothing concrete to check them against here.
Checks
npm run verifypasses in full.