Skip to content

fix(claude-code): propagate installation failures - #1063

Open
Edd88-pixel wants to merge 1 commit into
coder:mainfrom
Edd88-pixel:eddy/claude-code-install-reliability
Open

fix(claude-code): propagate installation failures#1063
Edd88-pixel wants to merge 1 commit into
coder:mainfrom
Edd88-pixel:eddy/claude-code-install-reliability

Conversation

@Edd88-pixel

@Edd88-pixel Edd88-pixel commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Why

Claude Code installation failures could be logged while the module continued and reported success. The skip-install path could also complete without a usable pre-installed binary, leaving a workspace apparently configured while Claude Code was unavailable.

Changes

  • download the official installer to a temporary file with bounded retries and timeouts before execution
  • validate the installer syntax, propagate download and installation failures, and verify the installed binary
  • require a usable pre-installed binary when installation is disabled and expose its resolved path to later configuration steps
  • cover installation, binary validation, authentication, MCP, telemetry, and provider scenarios with deterministic module tests
  • bump the module patch version to 5.4.1

Validation

  • E2E container tests completed successfully: bun test main.test.ts — 26 passed, 0 failed (196 assertions)
  • Terraform tests: terraform test — 27 passed, 0 failed
  • Terraform configuration: terraform validate — passed
  • TypeScript: bun x tsc --noEmit — passed
  • Formatting: targeted Prettier checks and terraform fmt -check — passed
  • Shell: ShellCheck on the rendered installer template — passed

@Edd88-pixel
Edd88-pixel marked this pull request as ready for review August 19, 2026 18:26
@Edd88-pixel
Edd88-pixel requested a review from 35C4n0r August 19, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant