-
Notifications
You must be signed in to change notification settings - Fork 135
🤖 fix: deliver terminal wakes for kernel-launched background workflow runs #3990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ibetitsmike
wants to merge
39
commits into
main
Choose a base branch
from
mike/workflow-kernel-terminal-wake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,900
−94
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
9665489
🤖 fix: deliver terminal wakes for kernel-launched background workflow…
ibetitsmike f41cbfb
🤖 fix: persist workflow_resume terminal consumption for kernel-nested…
ibetitsmike a19c5a3
🤖 fix: let newer sidecar records outrank consumed results; clamp futu…
ibetitsmike 30a3437
🤖 fix: reject persisted future-dated sidecar references instead of cl…
ibetitsmike 89263dd
🤖 fix: fail safe after full history clear; dedupe sidecar references …
ibetitsmike 59ce349
🤖 fix: tolerate bounded backward-clock skew in sidecar reference parsing
ibetitsmike 76e6e80
🤖 fix: decide kernel workflow currentness by boundary-row identity, n…
ibetitsmike 046286a
🤖 fix: never persist a boundary snapshot from an unreadable history; …
ibetitsmike e5de1dd
🤖 fix: migrate pre-snapshot sidecar references through a wall-clock f…
ibetitsmike 60bb82d
🤖 fix: deliver kernel workflow wakes launched from a decision-free hi…
ibetitsmike a73a354
🤖 fix: harden kernel workflow wake delivery against sidecar faults
ibetitsmike 983d3c5
🤖 fix: retire kernel workflow run references on a full history clear
ibetitsmike 56c789b
🤖 fix: close round-10 wake-delivery gaps: retirement ordering, record…
ibetitsmike 521fba2
🤖 fix: close round-11 gaps: record retry, indeterminate recovery, cle…
ibetitsmike 3eb19a5
🤖 fix: close round-12 lifecycle gaps for kernel workflow wake provenance
ibetitsmike 62dd290
🤖 fix: round-13 sidecar lifecycle hardening: boundary repair, removal…
ibetitsmike 6866c5b
🤖 fix: round-14 provenance integrity: supersede-older retries, genera…
ibetitsmike e14574d
🤖 fix: restore the caller tool policy on kernel workflow wakes
ibetitsmike 95ca943
🤖 refactor: strip rounds 11-14 retry/repair machinery; keep identity-…
ibetitsmike d35491c
🤖 fix: resolve the wake's agent identity with an unbounded history walk
ibetitsmike 0792396
🤖 fix: sanitize persisted wake restrictions before restoring them
ibetitsmike 9280614
🤖 fix: persist kernel workflow provenance before the runner can reach…
ibetitsmike 42a596b
🤖 fix: preserve the caller tool policy through on-send compaction fol…
ibetitsmike c59964f
🤖 fix: record resume provenance only after the dispatch restarts the run
ibetitsmike 2befd06
🤖 fix: restore the strict-agent pin on terminal wakes
ibetitsmike 36bb23c
🤖 fix: forward the object-form strict-agent pin on terminal wakes
ibetitsmike cf0323c
🤖 fix: stop compaction recovery from clobbering preserved follow-up f…
ibetitsmike 9f57ada
🤖 fix: bind workflow terminal wakes to the initiating agent
ibetitsmike 125aae5
🤖 fix: schema-validate persisted initiating agent IDs
ibetitsmike e1b1954
🤖 fix: split coalesced workflow wakes by initiating agent
ibetitsmike cb31308
🤖 fix: isolate wake identity groups and honor synthetic launch pins
ibetitsmike 8e1bcd6
🤖 fix: harden wake provenance writes, reads, and pin pairing
ibetitsmike d53ac1a
🤖 fix: defer boundaryless workflow references instead of wall-clock o…
ibetitsmike cd1b200
🤖 fix: split wakes by launch pin and repair downgrade-stripped proven…
ibetitsmike 578d72b
🤖 fix: gate crash-resume provenance repair on supersession-free evidence
ibetitsmike 56171b7
🤖 fix: make crash-resume boundary repair a compare-and-set under the …
ibetitsmike 6776f48
🤖 fix: defer identity-less wakes and wire terminal attention into cra…
ibetitsmike ce9085a
🤖 fix: retain and retry failed workflow terminal attention enqueues
ibetitsmike 7edfe81
🤖 fix: harden workflow wake recovery (resume reset, repair retry, res…
ibetitsmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For router-managed resumes or retries whose previous workflow notification is already delivered or superseded, a transient failure deleting that notification rejects this callback, but
WorkflowService.notifyRunStatusChangedcatches the error and starts the runner anyway. When the run settles,enqueueIfAbsentpreserves the stale terminal status, so neither the live callback nor startup recovery creates the new wake; make this reset a required durable precondition for restarting, or retain and retry it before terminal settlement.AGENTS.md reference: AGENTS.md:L112-L112
Useful? React with 👍 / 👎.