馃 fix: focus main region after sidebar collapse - #3995
Closed
tracyjohnsonux wants to merge 1 commit into
Closed
Conversation
Author
|
Closing because this change targeted the wrong repository. The requested fix belongs in coder/coder. Generated by Coder Agents on behalf of @tracyjohnsonux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focus the active route's main region after a sidebar collapse so keyboard input is not left on the collapsed rail button. Workspace, project creation, and scratch routes focus their chat composer; settings and analytics focus their main content region.
Background
When both side panels are collapsed on desktop, the last clicked collapse button can keep focus. Pressing Enter then re-activates the rail button instead of sending the chat message. This change routes sidebar collapse through a route-owned main-region focus event rather than hard-coding every collapse to the chat input.
Implementation
FOCUS_MAIN_REGIONcustom event and auseFocusMainRegionhelper.Validation
bun test src/browser/hooks/useFocusMainRegion.test.tsx src/browser/components/SidebarCollapseButton/SidebarCollapseButton.test.tsxbun test src/browser/components/ProjectPage/ProjectPage.autofocus.test.tsx src/browser/features/Settings/SettingsPage.test.tsxmake typecheckmake lintmake static-checkwas attempted but the workspace is missinguvxandhadolint; other static-check subtasks that ran passed, including formatting and code-to-docs links.Risks
Low. The new event is route-scoped by whichever main route is mounted, and sidebar expansion does not request focus. The hidden/inert guard prevents immersive overlays from returning focus to a hidden composer.
Generated with Coder Agents on behalf of @tracyjohnsonux.