Skip to content

docs: warn that GitHub blocks pull_request_target from December 2 - #317

Merged
shenxianpeng merged 1 commit into
mainfrom
docs/pull-request-target-block
Nov 2, 2026
Merged

shenxianpeng merged 1 commit into
mainfrom
docs/pull-request-target-block

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Before: Fork pull requests offers a pull_request_target workflow for posting comments on fork pull requests, with no word that GitHub starts blocking that event on December 2, 2026. A public repository that copies the example without adding an Actions policy finds the workflow no longer runs after that date.

After: an IMPORTANT note right above the example says what changes on December 2 and where to allow the event (Settings → Actions → Policies, scoped to this one workflow file), with links to GitHub's changelog and the "Control workflow execution" docs. It also says the App needs no such policy.

How

  • 10 lines added to docs/fork-pr-comments.md, nothing else changed. The README already points to this page for pull_request_target.
  • Dates and scope are taken from GitHub's changelog (enforcement moved to December 2 on October 21; public repositories without their own event policy; private and internal repositories are not affected).
  • pre-commit run --files docs/fork-pr-comments.md passes.

Summary by CodeRabbit

  • Documentation
    • Updated guidance to note that public GitHub repositories need an Actions event policy to run pull_request_target workflows after December 2, 2026. The guidance recommends limiting the policy to the relevant workflow file and clarifies that the App does not require it.

@shenxianpeng
shenxianpeng requested a review from a team as a code owner November 2, 2026 20:35
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1aae14f9-6f09-47b1-a586-9d2c920c278b
Commits

Reviewing files that changed from the base of the PR and between fb26099 and 4efb705.

Files selected for processing: 1
  • docs/fork-pr-comments.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The documentation adds guidance about the pull_request_target event policy for workflows in public github.com repositories, effective December 2, 2026.

Changes: Event policy guidance

Layer / File(s) Summary
Add event policy notice
docs/fork-pr-comments.md
The guidance explains that workflows need a policy allowing pull_request_target to continue running. It directs readers to allow the event for this workflow file only and states that the App does not require the policy.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: documentation

Merge Risk: Minimal · up to 4efb7

The notice explains the upcoming workflow restriction and how to configure an exception. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main documentation change: warning that GitHub will block pull_request_target starting December 2.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Commit Check

✅ All 5 checks passed

Show all 5 checks
Commit message
  ✔ PR title (docs: warn that GitHub blocks pull_request_target from De...)
  ✔ Commit 1/1 (4efb705) (docs: warn that GitHub blocks pull_request_target from De...)
Branch
  ✔ Branch (docs/pull-request-target-block)
Author
  ✔ Author name (Xianpeng Shen)
  ✔ Author email (3353385+shenxianpeng@users.noreply.github.com)

commit-check 2.19.4 · Rules reference

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fb26099) to head (4efb705).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          661       661           
=========================================
  Hits           661       661           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxianpeng
shenxianpeng merged commit cde9eb6 into main Nov 2, 2026
25 checks passed
@shenxianpeng
shenxianpeng deleted the docs/pull-request-target-block branch November 2, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant