Repository navigation
Bump to Comunica 5.4.0 and allow variable SERVICE targets - #192
Merged
Merged
Conversation
Enables the new serviceAllowVariableTargets context option by default, so SERVICE clauses with a variable target work in the Web client. Queries here are authored by the user in their own browser, so the untrusted-query concern behind the upstream default does not apply. The option can still be overridden via the default or per-query context. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xnbt6ngFijhZGfKydZWY9o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@comunica/query-sparql,@comunica/runnerand@comunica/config-query-sparqlto~5.4.0, and updatesyarn.lock.Also enables the new
serviceAllowVariableTargetscontext option by default, soSERVICEclauses with a variable target work in the Web client.Upstream disables this option by default because the SERVICE target then comes from the queried data, which lets a query from an untrusted party dereference arbitrary sources. That concern does not apply here: queries in this client are authored by the user, and run in their own browser. The option is set as a default in
_getQueryContext, so it can still be overridden through the widget's defaultcontextor through a per-query context.Verification
yarn lintpassesyarn dev-cibuilds successfully against 5.4.0馃 Generated with Claude Code
https://claude.ai/code/session_01Xnbt6ngFijhZGfKydZWY9o
Generated by Claude Code