chore: remove unused dependencies and rename Prost generator - #332
Merged
Merged
Conversation
Remove the unused public grpcio Prost generator from ttrpc-compiler and its Prost 0.8 dependencies. Bump compiler and codegen versions for the API and dependency changes. Remove unused direct dependencies from the Prost generator and example manifests; keep tempfile only for compiler tests. Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
chore/remove-unused-deps
branch
from
September 23, 2026 03:50
0ff81d2 to
ae4c449
Compare
Tim-Zhang
changed the title
Tim-Zhang
force-pushed
the
chore/remove-unused-deps
branch
from
September 23, 2026 07:21
2cec553 to
b29c15d
Compare
Tim-Zhang
force-pushed
the
chore/remove-unused-deps
branch
from
September 23, 2026 07:31
b29c15d to
ae4c449
Compare
Rename the unpublished Prost generator package to `ttrpc-codegen-prost` at 0.1.0 and move its source directory. Update the Prost example, CI, package links, and release docs. Preserve the newer generator guide while updating imports and paths. Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
changed the title
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Partial async modes fail for streaming schemas through generation panics or non-compiling bindings.
Review effort: Balanced
Findings: None
What changed in this PR
Removes unused dependencies and legacy compiler APIs while renaming the standalone Prost generator.
Changes:
- Removes legacy compiler Prost/grpcio generation and bumps crate versions.
- Renames the Prost generator and updates examples, CI, and documentation.
- Cleans unused dependencies and adds release notes.
| File | Description |
|---|---|
ttrpc-codegen/CHANGELOG.md |
Records compiler dependency update. |
ttrpc-codegen/Cargo.toml |
Bumps version to 0.6.1. |
ttrpc-codegen-prost/tests/codegen_proto.rs |
Updates imports and test paths. |
ttrpc-codegen-prost/src/util.rs |
Provides generator naming utilities. |
ttrpc-codegen-prost/src/svcgen.rs |
Implements Prost service generation. |
ttrpc-codegen-prost/src/lib.rs |
Updates setup-guide link. |
ttrpc-codegen-prost/src/codegen.rs |
Updates crate naming in generated output and docs. |
ttrpc-codegen-prost/README.md |
Documents the renamed generator. |
ttrpc-codegen-prost/Makefile |
Adds standalone build and check targets. |
ttrpc-codegen-prost/CHANGELOG.md |
Adds initial release history. |
ttrpc-codegen-prost/Cargo.toml |
Renames and versions the crate. |
src/lib.rs |
Updates runtime documentation links. |
RELEASE.md |
Adds standalone publishing instructions. |
README.md |
Updates setup, links, and commands. |
example/Cargo.toml |
Removes unused example dependencies. |
example-prost/README.md |
Updates generator paths. |
example-prost/Cargo.toml |
Renames build dependency and removes unused dependencies. |
example-prost/build.rs |
Updates the generator import. |
compiler/src/prost_codegen.rs |
Removes legacy grpcio Prost generation. |
compiler/src/lib.rs |
Removes the legacy public module. |
compiler/CHANGELOG.md |
Documents the breaking removal. |
compiler/Cargo.toml |
Bumps version and removes unused dependencies. |
Cargo.toml |
Updates workspace exclusions and dependency versions. |
.github/workflows/bvt.yml |
Updates standalone generator CI paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lifupan
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies from the compiler, standalone Prost generator, and examples. Drop the compiler's unused public grpcio Prost 0.8 module, bump
ttrpc-compilerto 0.9.0 for that API removal, and bump the dependent rust-protobufttrpc-codegento 0.6.1.Rename the unpublished Prost generator to
ttrpc-codegen-prost0.1.0 and move it tottrpc-codegen-prost/. Update imports, example dependencies, CI, and release documentation while preserving the newer Prost setup guide.