Skip to content

fix(deps): raise fast-uri override to ^3.1.7 (2 high) (+Claude) - #231

Merged
dhruv-parekh-cs merged 1 commit into
developmentfrom
CL-snyk-fixes/03-Sep-2026-development
Sep 3, 2026
Merged

fix(deps): raise fast-uri override to ^3.1.7 (2 high) (+Claude)#231
dhruv-parekh-cs merged 1 commit into
developmentfrom
CL-snyk-fixes/03-Sep-2026-development

Conversation

@dhruv-parekh-cs

Copy link
Copy Markdown

Summary

Re-target of #230 onto development (that PR was opened against main; closing it in favour of this one).

One line changed. development already carries almost all of the dependency work — this closes the single remaining gap.

Issue Severity Package Before → After Bucket Rationale
SNYK-JS-FASTURI-19502739 · -19502854 high ×2 fast-uri (transitive) override floor ^3.1.6^3.1.7 fixable 3.1.6 still resolves inside the vulnerable range (fixedIn: 2.4.6 / 3.1.7 / 4.1.4). Stays on the 3.x line — no major move — and stays a caret so future patches float in.

Verified against a pristine development checkout: it resolves fast-uri@3.1.6 and snyk test reports it high. With this change it resolves 3.1.7 and that finding is gone.

Why this replaces #230 rather than being retargeted

#230's branch was cut from main, and the two bases have divergeddevelopment is 13 commits ahead of main, main is 6 ahead of development. Simply switching #230's base would have dragged those 6 unrelated main commits into development:

2a91159 Update release.yml
932e144 Update release.yml
9f95302 Update release.yml
b23e2ad Update CODEOWNERS
647f26d Merge pull request #226 from contentstack/cl-0000
8c37b40 chore:update package-lock.json file

touching .github/CODEOWNERS, .github/workflows/release.yml, .talismanrc and package-lock.json. So this is a fresh branch off development carrying only the dependency change.

What #230 proposed that development already has

Worth recording, because it's most of that PR:

#230 proposed State on development
Scope uuid override to its parent Already present"istanbul-lib-processinfo": { "uuid": "^11.1.1" }, the exact scoped form #230 arrived at after review
serialize-javascript ≥ 7.1.1 Already present^7.1.0 resolving 7.1.1
adm-zip0.6.0 (which #230 declined as a breaking change) Already taken, and src/adapters/file-upload.ts already adapted: the if (!status) success-flag check is gone, replaced by try/catch around writeZipPromise

That last one is the behavioural decision #230 explicitly routed to a human rather than guessing at — it has since been made here, correctly.

⚠️ One finding for a human — adm-zip

snyk test on development reports adm-zip@0.6.0 as high with fixedIn: [], both before and after this change. So the major bump to 0.6.0 did not resolve the advisory, and no fixed release currently exists. Out of scope for this PR; flagging it so it isn't assumed handled by the version bump.

Self code review

One review round. No High or Medium findings.

  • Minimality — diff is 1 line in package.json and 3 in package-lock.json; confirmed fast-uri is the only package whose version moved.
  • Version specificity — loosest safe caret on the same major line; the advisory gives no reason 3.x must not float.
  • Override hygiene — raised an existing floor rather than adding a new entry; nothing else in overrides touched.
  • No stray formatting — an earlier edit added a trailing newline this file doesn't use; reverted so the diff stays at one line.
  • .talismanrc — no change needed. development allowlists package-lock.json via ignore_detectors: filecontent, not a checksum pin, so the checksum churn that affected the main-based PR doesn't apply here.

Validation

  • npm install — clean · npm run build — green
  • npm test137 tests, 8 suites, all passing
  • snyk test — the two fast-uri highs cleared; only the unfixable adm-zip high remains
  • npm audit — 0

Local note (not a repo issue): installing in the workspace checkout 404s on @contentstack/cli-utilities@1.18.5 because the repo-local .npmrc routes @contentstack/* to GitHub Packages while that package lives on public npm. A pristine checkout without that .npmrc installs fine, which is where the validation above was run.

SNYK-JS-FASTURI-19502739 / SNYK-JS-FASTURI-19502854 (both high). The existing
override floor of ^3.1.6 resolves to 3.1.6, which Snyk reports as vulnerable
(fixedIn: 2.4.6 / 3.1.7 / 4.1.4). Raising the floor to ^3.1.7 keeps the fix on
the 3.x line - no major move - and stays a caret so future patches float in.

This is the only dependency gap left on development: it already carries the
scoped istanbul-lib-processinfo > uuid ^11.1.1 override, serialize-javascript
^7.1.0 (resolving 7.1.1), and adm-zip ^0.6.0 with file-upload.ts already
adapted to writeZipPromise's void return.

Validation: fast-uri resolves 3.1.6 -> 3.1.7; snyk high cleared; build green;
137 tests + 8 suites passing.

Note: adm-zip@0.6.0 is still reported high by Snyk with fixedIn: [] - the major
bump on development did not resolve it and no fixed release exists. Out of scope
here; flagged for a human.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 3, 2026 10:12
@dhruv-parekh-cs
dhruv-parekh-cs requested review from a team as code owners September 3, 2026 10:12
@snyk-io

snyk-io Bot commented Sep 3, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 1 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 1
  • Medium without fixes: 0
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, consistent dependency override bump with the lockfile updated accordingly.

Pull request overview

This PR updates the npm overrides floor for the transitive dependency fast-uri to ensure the resolved version is 3.1.7, addressing the referenced high-severity Snyk advisories while staying on the 3.x line.

Changes:

  • Bump fast-uri override from ^3.1.6 to ^3.1.7 in package.json.
  • Update package-lock.json to reflect resolution of fast-uri@3.1.7 (including new tarball URL and integrity hash).
File summaries
File Description
package.json Raises the fast-uri override floor to ^3.1.7.
package-lock.json Updates the resolved fast-uri entry to 3.1.7 with matching metadata.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dhruv-parekh-cs
dhruv-parekh-cs merged commit 916fe9e into development Sep 3, 2026
9 checks passed
@dhruv-parekh-cs
dhruv-parekh-cs deleted the CL-snyk-fixes/03-Sep-2026-development branch September 3, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants