Repository navigation
Conversation
Point::instance_id is std::int64_t. copick writes Python ints, and the reflect-cpp read into an int narrowed any id >= 2^31 without an error. Filament ids are instance ids, so a tracer that numbers filaments globally reaches that range. BREAKING CHANGE: Point::instance_id changes from int to std::int64_t, which changes the layout of Point and the ABI. Consumers (AreTomo3) rebuild; code that assigns an int keeps compiling. New C++11 public header copick/filament.h: FilamentSpec (polar, helical_rise_a, helical_twist_deg), filament(obj) and is_filament(obj) read the spec copick >= 1.28 stores at metadata["copick"]["filament"]. An absent or null spec, or a "copick" value that is not an object, is not a filament; unknown spec keys are ignored; a spec copick refuses (not an object, wrong field types, helical_rise_a <= 0, or on a non-particle object) throws ValidationError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uermel
marked this pull request as ready for review
October 5, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
64-bit instance ids.
Point::instance_idis nowstd::int64_t. copick writes Python ints, and the reflect-cpp read into anintnarrowed any id ≥ 2³¹ without an error. Filament ids are instance ids, so a tracer that numbers filaments globally reaches that range.Filament spec accessor. New C++11 public header
copick/filament.hwithFilamentSpec(polar,helical_rise_a,helical_twist_deg),filament(obj)andis_filament(obj). They read the spec copick ≥ 1.28 stores atmetadata["copick"]["filament"](copick/copick#479), with copick's semantics:nullspec, or a"copick"value that is not an object, is not a filament;ValidationError: not an object, wrong field types,helical_rise_a ≤ 0, or set on a non-particle object.It is added to
copick.hand to the C++11 header guard.Tests
PicksJson.InstanceIdsAre64Bit: reads and round-trips 4294967296 and 9007199254740993.Filament.*: spec read; absent, null and foreign namespaces; invalid specs throw.cmake --preset devwith GCC 13.3: 33/33 pass, includingcxx11_header_guard. Formatted with clang-format 18.1.8.🤖 Generated with Claude Code