Repository navigation
Fit RViz's window to the Mac's virtual display - #36
Merged
Merged
Conversation
The RViz configs keep the lab monitors' window geometry (the H1-2's at x = 1990, 1245x1376), so on the Mac's 1280x800 Xvfb display RViz drew entirely off-screen and noVNC showed black. vnc_display.sh now starts matchbox-window-manager, which fits each window to the screen; checked in a fresh golem_ros container: RViz at 1280x800+0+0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7pDNJLWR31eQmyKaWhr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fit RViz's window to the Mac's virtual display
Follow-up to #34. On the Mac, RViz ran but the browser view (http://localhost:6080/vnc.html) was black. The RViz configs keep the lab monitors' window geometry; the H1-2's
main.rvizputs the window at x = 1990, 1245×1376 px. On the Mac's 1280×800 Xvfb display, that is entirely off-screen.Change
docker/mac/RosDockerfile: installsmatchbox-window-managerwith the display packages.docker/mac/vnc_display.sh: starts it with the display. It fits every window to the screen, with no title bars.No RViz config, launch file or x86 file changes.
Testing
golem_roscontainer from the rebuilt image,rviz2 -d .../rviz/h12/main.rvizopens at1280x800+0+0(xwininfo -root -tree), with no manual steps.After merging, run
docker/scripts/docker_build.sh roson a Mac to pick it up.🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7pDNJLWR31eQmyKaWhr