Skip to content

Restore per-cluster view spike budgets#1399

Merged
rossant merged 5 commits into
masterfrom
agent/per-cluster-view-budgets
Jul 24, 2026
Merged

Restore per-cluster view spike budgets#1399
rossant merged 5 commits into
masterfrom
agent/per-cluster-view-budgets

Conversation

@rossant

@rossant rossant commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make Waveform, Amplitude, and Correlogram sampling fixed per cluster by default while retaining optional shared total caps
  • prevent dataset-local view state, including the Firing Rate time range, from leaking through global GUI state
  • clarify budget semantics, Firing Rate behavior, configuration examples, and troubleshooting documentation

Why

A shared total budget makes per-cluster sampling accuracy decrease as more clusters are selected. Both policies are useful, so the per-cluster ceilings remain primary and an integer *_total value opts into a shared cap. Separately, a stale globally persisted Firing Rate x_max could clip spikes in fresh datasets.

Validation

  • make lint
  • make format-check
  • make doc-check
  • core/GUI phase of make test-full: 363 passed, 1 skipped
  • application suite against phylib master db10401589b47fd8d56f7c66531b0c22fc7f9e91: 133 passed
  • focused GUI state and histogram regressions: 8 passed

The locked PyPI phylib 2.7.0 predates the existing spikes_are_disjoint selector argument already used on master; current phylib source is required for the application suite.

@rossant
rossant merged commit 67a8256 into master Jul 24, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant