Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native/Git staging, selected Xet publication, captured hydration and protected receive need to run together on one source tree. This integration brings the selected-publication, xorb format-limit and protected-receive changes onto the existing unified staging and captured hydration branch. It adds checks that publication does not widen older hydration captures and that shared catalog reads preserve close and abandonment behavior.
Stacked on #581 (
codex/selected-catalog-consumers,43203ff48f6), which includes #578's canonical ingestion and staging-retirement implementation. Imports #579, #580 and #583; production code applied without conflicts. Documentation retains both consumer descriptions. The current-state capture extraction in #582 remains a separate series.Additional qualification:
Validation on the frozen
a6eeca4319dtree, guarded by 1,224 Rust source/manifest/lock hashes:simd-accel,gix-pathmatch,nfsand no default features. Its 12 minimal-profile warnings are not a strict CLI-lint pass.A subsequent CLI lib-test build found an imported test still calling the now-async
git_visibility_indexsynchronously. This PR also adds its missingawait, retaining the policy/visibility assertions. The focused force-rewrite positive control now passes, retaining its six force/lease/deny policy cases and visibility assertions. Two new captured-reader GC regressions fail on the unchanged production implementation: after either ref movement or readiness replacement, repository GC deletes an aged physical-index body even though the reader was just captured and its pages remained cold. Both fail with the expected typed storageNotFound; the runtime result is retained separately from the earlier compile failure. Retained-reader lifecycle correctness is therefore a confirmed open gate, not an inferred risk.The official native installation and the six-case 10 GiB matrix use a separate frozen
a6eeca4319dcheckout. Those source-bound results will be component evidence for that exact tree, not a claim about later source changes. Installation and qualification are still pending.Evidence map:
crab add, Git clean/push,Prepared::upload_capsule, protectedverify_receive, revision downloads and remote mount setup.PointerCatalogLookup::dependencies. Snapshot/mount hydration passesSharedFileIndexLookup::for_pointer_catalogto the canonical hydrator and StoreClient. All xorb admission variants use the same hard format-limit rollover. Protected receive validates filtered/incoming Git visibility before installing private source packs.origin/mainatcc2e4e25f46eeaee3cfd30025d257397c17a6049is an ancestor; the unmerged series supplies the capsule/staging changes. This PR is an integration gate, not a main-level completion verdict. All 19 audited local release tags omit the captured catalog constructor; no compatibility API is added.Is this the best fix? It exercises the existing canonical staging and catalog owners on one tree rather than adding a competing hydration implementation. The additional tests cover their shared snapshot and cleanup contracts. Imported production changes retain their separate review history.
Remaining release gates: source-bound integrated 10 GiB alternating native/Git edits and pushes, cold historical reconstruction, full protocol/provider and mounted runtime qualification, lifecycle/GC/publication races, current-state capture, representative hosted-S3 cold/warm latency and fuller Git blame semantics. Earlier binaries and sibling-branch receipts are component evidence only. No merge or production rollout is included.
The two requested benchmark audit reports and the user-owned advisor plan are excluded.