Repository navigation
Conversation
Cache bounded file-to-shard answers after complete dependency proofs. Preserve requested-key admission and full-batch proof accounting on misses; never hold the cache lock across origin I/O.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated file-to-shard lookup for a 10 GiB file rebuilt its authenticated recipe after the generic page cache evicted it: both cold and warm batches issued 497 range reads and fetched 7,434,846 bytes. Retain compact verified bindings within the captured file-index session so a fully cached batch needs no origin reads.
Stacked on #584. No format, dependency, configuration or public API changes.
Behavior
Validation
file-index-readerand-D warningspassed. Payload-only compilation, storage-only compilation and the real qualifier build passed. Format and whitespace checks passed.91d437990f626aa39b3473588c0f3995ef246d445fc0726eaa79a849ff003837; result JSONL SHA-2564a5999c73ab4c28e4cc7cfeef0e984b0569d276de0eaf6195144a1f8b2a25eb4.Evidence map
FileIndexLookupSession::lookup_batchincrates/crab-metadata/src/file_index_lookup.rs; current and captured catalog constructors share the same private sessioncatalog_session.rsowns compact verified results;PointerCatalogLookup::filesretains complete authenticated closure and canonical orderingcapsule_protocol/pointer/paged/reader.rs; existing page/query limits remain unchangedfile_index_lookup/catalog_tests.rsand the bounded binding-cache property; existing file-index lifecycle tests passIs this the best fix? Cache the small verified answer at its consumer boundary instead of increasing a generic page cache to fit one file size or weakening the initial dependency proof. About 110 net production lines own bounded results, preserve admission and replace the previous inline catalog conversion. Review the deliberately complete proof on partially uncached batches and the remaining combined qualification before readiness.
The two requested large-file audit reports remain excluded. No assertion baseline, architecture inventory or expected-failure list is relaxed.