Repository navigation
Conversation
An unopened global index cannot supply per-chunk absence facts. Keep that state in the existing OnceCell instead of persisting a negative row for every chunk in a new file. Preserve initialized-index cache policy, cancellation, close ownership and push-side proof validation.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fresh protocol-v2 bucket, native
crab addopens the optional legacy global chunk index and correctly remembers that it is uninitialized. The classifier nevertheless wrote one advisory negative SQLite cache row per chunk. An actual 64 MiB add produced 1,037 such rows despite the index being absent before and after the command.Persist candidate-cache updates only after the shared index has actually opened. Keep absence of the entire index in the existing command-scoped
OnceCell. Initialized index snapshots keep their current positive/negative cache behavior. Candidate selection, local payload ownership, cancellation, explicit close and push-side proof validation are unchanged.Draft, stacked on #587 (
codex/catalog-current-integration). Separate from the browse-retention changes in #591. No merge requested.Validation
simd-accel,gix-pathmatchfeature slice. Existing unrelated feature warnings remain.Review evidence
AddRemoteChunkClassifier; its existingExistingChunkLookupimplementation owns advisory candidate-cache writesNone; other errors propagateIs this the best fix? Cache the fact at the scope where it is known: absence of the whole index belongs to the current lookup session. Removing these writes requires no schema migration or new option and preserves the initialized-index contract.
This does not integrate native add with the v2 catalog or solve the roughly 10 GiB of local payload writes still observed for small edits. Those remain separate staging work. The two excluded large-file audit reports and the user-owned advisor plan are not included.
Live integrated verification (909a40a2559):