Repository navigation
Conversation
Share bounded hash verification and its existing corruption retry with acknowledged immutable writes. Retry only the GET and retain both identity fields from the response whose bytes passed verification. Persistent corruption still fails after two reads; exact and logical writes issue one PUT. Keep checksum-qualified and occupied-key contracts unchanged.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A readback-required immutable write returned a corruption error after its first wrong hash response, while ordinary verified reads already applied the shared one-retry corruption policy. This could abort large-file publication even when the stored origin bytes were healthy. The #598 fresh 10 GiB run exposed a readback digest failure; direct origin/local bytes matched afterward and a diagnostic retry audited 161 matching bodies. The cause of that original response remains unresolved.
Route exact immutable-write readback through the existing bounded verifier. Logical creates use the same private verifier and retain both ETag and version from the response whose bytes passed verification. Only GET is retried; the acknowledged PUT is not replayed. Persistent corruption still fails under the existing
FatalAfterOneRetryrule. Checksum-qualified creates, occupied logical keys, byte ceilings and source-error propagation keep their existing contracts. Production hash-verification duplication is reduced.Stacked on #598, independently of the opening/format work. No wire format, public API, retry option or dependency changes.
Validation on
5c58a939d6c:Evidence map: CLI Xet publication, shared preparation and protected dependency publication call the logical-create API; capsule/shard/checkpoint/source-root publication calls exact verified create.
crab-storageowns provider I/O, bounded framing, hash verification and retry classification.verified_bodyshares the standalone verifier’s policy and binds the accepted response identity. Current main already applies that corruption retry to ordinary verification; these newer immutable-create APIs live in the integration stack. Streaming size/hash verification uses the same retry class and is unchanged. Existing tests cover qualified checksums, different valid occupied encodings, staged routing, bounded/streamed reads and operation-bound identities.Is this the best fix? Reuse the existing verification owner instead of adding retries to each publisher, replaying PUTs, relaxing hashes or exposing another setting. Returning the verified GET identity is necessary for logical creates; standalone verification discards only that extra identity.
This is a component recovery fix, not a completed 10 GiB matrix. Fresh full-matrix, larger lifecycle/performance qualification and the rest of the indexed-remote initiative remain required. The advisor plan and both excluded large-file audit reports are absent from this two-file diff.