Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared residual reads returned every requested decoded chunk from a source xorb at once, even when the Git packer supplied a small batch budget. Keep one verified serialized source in the staging read plan and return bounded, independently owned decoded batches. Switch the existing Git packer to the bounded method.
Pin source descriptors before queuing workers. The plan retains each worker handle and buffered result, so cancelling a read cannot lose chunks; resuming with smaller limits splits the queued output to the new budget. Worker-owned activity accounting closes on every worker exit. Shared source and chunk helpers retain full size, raw BLAKE3, logical xorb, footer-payload and decoded-chunk verification.
The public complete-source
read_nextAPI is present in release tag v1.2.4 (76977b2af19) and current main. Preserve that contract, sharing the same integrity checks; canonical consumers migrate toread_next_bounded. Removing the released method requires a breaking library release. No dependency, format, schema, configuration or lockfile changes.Stacked on #598. The separate capsule incremental-upload change will consume this reader as well; it is not included here.
Validation on
51b7d6956e8:Fresh native-CLI RustFS qualification on dependent combined commit
4a9b8059d4epassed 75 commands / 57 checks: two 64 MiB entropy files, four versions through alternating native/Git staging, no second full local payload, retired published staging owners, eight independent cold byte oracles and full remote integrity. New xorb bytes per version were 67,156,162 / 2,216,454 / 2,284,332 / 2,354,458. Source and CLI hashes stayed unchanged. This is component E2E proof, not the final 10 GiB matrix.Evidence map:
PushPipeline::xorbscalls the staging read plan aftermark_staging_push_reader_if_needed/snapshot_staging_recipes_if_neededpin selected recipe leases. SQLite temporary rows select canonical segment/prepared authority; file descriptors are pinned before worker admission.load_prepared_sourceanddecode_prepared_chunkshare the existing Xet parser checks with ordinary staged reads and the released complete-source API. Tokio 1.53.1 documents awaiting&mut JoinHandleas cancellation safe; storing that handle preserves the queued result. Existing publication/retirement ordering is unchanged. Current main retains the complete-source behavior rather than this bounded cursor.Is this the best fix? Staging owns source grouping, byte verification and reader lifetime. Keeping pending work and bounded output there avoids separate caller caches or integrity readers. The explicit released API is the reason the full-source method remains.
Remaining gates: native CLI and cross-platform qualification for this exact change, and the larger initiative's final-source matrix/lifecycle/hosted-S3 gates. The earlier 10 GiB recovery evidence predates this change and is not claimed for it. This draft is not ready to merge. Both excluded benchmark reports and the advisor plan are absent.