Repository navigation
Conversation
Use the existing futures lock for read-ahead lanes and remove the test diagnostic rejected by the metadata scope gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata storage gained a new direct Tokio feature edge for cache read coalescing, which violates its approved feature budget. Use the existing futures mutex for the same four hashed read-ahead lanes, and remove the test debug print rejected by the metadata source-scope gate. Read-ahead ranges, cache capacity, page authentication and query admission bounds stay unchanged.
Stacked on #609. No dependency versions, lockfiles, inventories or test bounds change.
Validation:
Dependency contract: the locked futures-util 0.3.32 mutex removes queued waiters on cancellation and unlocks through its guard's drop. The cache uses its lock only for cold block coalescing; publication/ref ordering is owned elsewhere. Futures mutexes do not promise FIFO admission, and this private cache path does not use FIFO ordering for correctness.
Evidence map: PageCache lookup/scan -> fetch -> read_block serves both visibility proofs and selected catalog pages. Existing cache tests retain authentication, shared cache bounds and cold/warm admission checks; the catalog-opening regression retains its request assertions and diagnostic assertion message. The #609 baseline introduced the direct Tokio edge and print. Current main has no capsule-protocol layered checkpoint module.
Is this the best fix? Reuse the already approved async primitive at the existing cache owner, preserve the four-lane design and cancellation behavior, and remove the diagnostic rather than relaxing source/feature inventories.
The user's advisor-plan changes and both excluded benchmark audit files are absent.