Repository navigation
fix(macos): say kept, not installed, when a rerun keeps the existing binary - #28
Merged
Merged
Conversation
…binary Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Christian Catalan <crcatala@gmail.com> (cherry picked from commit 0bdbbb2)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Christian Catalan <crcatala@gmail.com> (cherry picked from commit c0b62f3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27 (these two commits were pushed after it merged).
Running
sh macos/install.shwithout options keeps the binary that's already installed, but the output said✓ installed. It now says✓ kept;--latest,--versionand--binarystill sayinstalled. Plus a Prettier fix for the test file.Seen on a real Mac (macOS, Apple Silicon) re-running the installer over the 0.0.2 layout: every other line was as expected.
Testing
pnpm format:checkpasses🤖 Generated with Claude Code