Skip to content

Strongly Typed AthenaError #35

Description

This particular assertion kinda gives me an idea that this test is too tightly coupled to exactly what the error handling logic will do re: strings.

Wonder if it's better to make more, strongly typed, errors that inherit from AthenaError like AthenaAffiliateAuthError or something. Can do that in a way that's not breaking to previous version's code too since they'll except AthenaError.

Originally posted by @snus-kin in #27 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions