Repository navigation
Accidental PR - #124
Closed
montehoover wants to merge 3 commits into
Closed
Accidental PR#124montehoover wants to merge 3 commits into
montehoover wants to merge 3 commits into
Conversation
parse_data_element already skips unknown XML attributes with a warning,
but a <FlexStatement> section it has no attribute for was passed straight
to the dataclass constructor and blew up the whole parse:
FlexParserError: FlexStatement - FlexStatement.__init__() got an
unexpected keyword argument 'MutualFundDividendDetails'
Treat contained elements the same way as attributes: warn and skip any
whose tag is not a field of the FlexElement subclass, so a section IB adds
after a release degrades to a warning and the known sections still parse.
Fixes #117.
… section Attributes taken from a real Flex statement (Mutual Fund Dividend Details section, all fields selected). Test case uses censored real-world data as requested in the README.
- subCategory="ETF" appears on every ETF row of the performance summary sections (7,523 rows in one 365-day statement), so typing subCategory as an enum in d87636d made those statements unparseable. - notes="XCH" appears on FUND trades routed via FUNDSERV with transactionType="ExchTrade" (a mutual fund exchange).
montehoover
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.