Repository navigation
Fix executable bank-transfer examples in the contributor tutorial - #211
Merged
csingley merged 1 commit intoOct 17, 2026
Merged
Conversation
Owner
|
Thanks @dajiaohuang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the existing examples in
docs/contributing.rst, as proposed in #209 and approved by csingley on 2026-10-16 at 14:45:13 UTC:SubAggregatefromofxtools.Typesand correct its documented location.INTRARQ.xferinfoatXFERINFO, andINTRATRNRQ.intrarqatINTRARQ.intra*fields.ofxtools.Typetoofxtools.Types, the bank message-set module path, and message-set bases toAggregate.STATUS,RECURRINST,Bool,ElementList,DAYS,Integer,ListElement,Time).The original snippets raise import/name errors or illustrate incorrect model relationships. This changes only the tutorial; production code, tests and message design are unchanged. The header/parser discussion in #208 and separate charset direction are not included.
Validation and limits
Reused historical validation from 2026-10-15 at base
7758d23e9923ae13bdb71761666f39ccd21faa3f: all 22 corrected Python blocks executed sequentially in a fresh namespace, and the tutorial-defined request/response wrappers round-tripped through productionAggregate.from_etree()using invented account identifiers. No real financial data or network operations were used.No tests, tutorial execution, Sphinx build or CI were run during this docs-only extraction. Historical validation is not a claim about current upstream HEAD or current CI.
Related: #209.