fix: honor Git file modes in Windows source bindings - #2
Merged
Merged
Conversation
Use indexed executable modes when core.filemode is false, preserving source identity across staging and commits while detecting index mode changes. Keep POSIX filename checks and construct quoted-path tree fixtures portably. Add non-POSIX mode regression coverage.
cskwork
marked this pull request as ready for review
September 16, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Git Bash treated reviewed files as having different executable modes from their commits, so valid deliveries failed source matching. Honor
core.filemode=falseby using index modes for tracked files and Git's non-executable default for new files. Keep filesystem mode checks where Git supports them, and reject explicit index mode changes after review.Make quoted-path fixtures portable: retain literal filename checks on POSIX, explicitly skip unrepresentable Win32 names, and construct a real quoted-path Git tree on every platform to verify rejection. Document the mode behavior in both READMEs.
Validation:
SELFTEST PASS;PASSED: 141 FAILED: 0;E2E PASS.git diff --checkpassed.Independent agent review was unavailable because the requested Claude Opus 5 reached its weekly usage limit. Host review and automated tests completed.