chore: declare inceptionYear 2019 and normalise copyright headers - #252
Conversation
<inceptionYear> is an inherited POM element, and the mycila license plugin
binds the copyright ${year} to project.inceptionYear - not to the current
year. cui-parent-pom held the only declaration in the hierarchy (2022), so
this project reported 2022 and every -Ppre-commit run restamped every
source header. Declaring the real year, taken from this repo's first
commit, stops that.
The 197 header changes are that one-time correction. Verified by running
the gate twice: the second run rewrites nothing and leaves a working tree
identical to the first, which is the property that was broken.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014sxAQc2ohWuDz65e2DbVij
There was a problem hiding this comment.
Sorry @OliverWolffGIP, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 3 days and 7 hours by commenting @sourcery-ai review. Upgrade to get a review now.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
<inceptionYear>is an inherited POM element, and the mycilalicense-maven-pluginbinds the copyright${year}toproject.inceptionYear— not to the current year:cui-parent-pomheld the only declaration in the hierarchy (2022), so this project reported 2022 and every-Ppre-commitrun restamped every source header. Declaring the real year stops that.The year
2019— from this repository's own first commit, not the parent and not GitHub'screated_at.What is in this PR
Two things, and it is worth being precise about the second:
pom.xmlgains<inceptionYear>2019</inceptionYear>, and the license plugin rewrites every source header to© 2019-present. This is the change being made.-Ppre-commitalso runs OpenRewrite, which reorders imports, reformats, and adds build-plugin blocks. Confirmed pre-existing: running the gate on unmodifiedmain, with noinceptionYearat all, produces the same kind of changes.It cannot be split out. The gate re-applies it on the next run, so a header-only tree would not be gate-stable — and gate-stability is precisely the property this PR exists to restore.
Verification
The gate was run twice. The second run rewrote nothing and left a tree identical to the first. That idempotence is what was broken, so it is the thing checked — not merely that the build passes.
Confirmed afterwards that every
.javaheader in the tree reads© 2019-present, with no stragglers on other years.