Repository navigation
validation: Drama 3 Metal command and buffer lifetime fixes - #15
Draft
cwschroeder wants to merge 2 commits into
Draft
cwschroeder wants to merge 2 commits into
cwschroeder wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation branch for the host-side lifetime fixes atop upstream #956 at
c6af3262, based on main46a08c18.Two commits drain a newly committed Metal command buffer if waiting for the previous one fails, and keep buffer registration and mapped-buffer ownership consistent on allocation errors. They do not change kernels or model arithmetic.
Local evidence at
5fd8de65: all 12 CPU transport/ownership cases pass in Debug and Fast; the unchanged PR head has three passing controls and nine failing cases. Whole-tree formatting, whitespace and lean comparison pass (517/517, zero new). The actual Metal CLI compiles with Zig 0.17.0 and Xcode 26.6 without execution. All six current-head checks are green on this validation PR, including the four complete No GPU commands, formatter and app/mobile workflows. No model, GPU execution or performance qualification is claimed, and nothing is deployed.