Repository navigation
tp: validate runner commands before opening a session - #18
Open
cwschroeder wants to merge 2 commits into
Open
cwschroeder wants to merge 2 commits into
cwschroeder wants to merge 2 commits into
Conversation
cwschroeder
marked this pull request as ready for review
October 17, 2026 14:13
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TP runner currently opens a session before rejecting an unknown command or parsing failfast numbers. A typo can therefore start fate threads and return without closing their session. This patch validates command syntax before configuration, CUDA and session startup.
It also rejects unknown failfast modes instead of treating them as fatal injections. Documented defaults and the explicit HOLD=0 host-only guard are preserved. Session ownership and transport code are unchanged.
Validation at
602a0fd4e1d621cf0715d01a2b466497dc3b4bb7:Pinned upstream PR ashhart#636 base:
46161ac46a4448e4b7179fba84e3554537a43319; main remains6ee828c24bf802cdd73507d6fc60bb27a82c0d66. This fork PR provides validation and a bounded patch for the existing upstream thread.Patch and source/compiler/binary hashes.