Skip to content

test: use DocumentsContract.moveDocument in external storage delete test - #439

Merged
cwuom merged 1 commit into
masterfrom
intention/fix-android-ci-external-move
Sep 25, 2026
Merged

cwuom merged 1 commit into
masterfrom
intention/fix-android-ci-external-move

Conversation

@cwuom

@cwuom cwuom commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

将外部存储删除测试中的文件移动操作改为调用 DocumentsContract.moveDocument,并继续验证旧映射目标无法解析、文件仍保留在目标目录。未改变应用行为或兼容性。

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: cwuom/NeriPlayer/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 40693bb2-d79f-419f-84ed-97f08680be53

📥 Commits

Reviewing files that changed from the base of the PR and between c4a8b38 and e833d26.

📒 Files selected for processing (1)
  • app/src/androidTest/java/moe/ouom/neriplayer/core/download/ManagedDownloadExternalStorageDeletePerformanceTest.kt

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

测试不再通过更新 MediaStore 的 RELATIVE_PATH 移动 JSON 文件。测试改为调用 DocumentsContract.moveDocument,将原文档移动到目标目录。测试仍验证原映射目标无法解析,且文件保留在目标目录。

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e833d

这项测试调整未显示会影响应用运行或部署的风险;没有已证实的问题阻碍合并。

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了测试改动:在外部存储删除测试中使用 DocumentsContract.moveDocument。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwuom
cwuom merged commit 6056c65 into master Sep 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant