fix(download): skip network recovery in test runtime and throttle delete progress publishing

[cwuom]

• 仪器测试运行时不再注册系统网络回调，避免启动网络恢复监视器。新增测试验证该监视器未注册。
• 删除下载歌曲时仍逐项更新成功和失败计数，但只在首次、每 32 次及最后一次尝试后发布进度。
• 未提供测试执行结果。

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: cwuom/NeriPlayer/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 9d7eaf84-abd9-401f-8339-f3a3324d4891

📥 Commits

Reviewing files that changed from the base of the PR and between b1cc3b6 and 37cfe9c.

📒 Files selected for processing (3)

• app/src/androidTest/java/moe/ouom/neriplayer/testing/InstrumentationTestRuntimeTest.kt
• app/src/main/java/moe/ouom/neriplayer/core/download/manager/catalog/GlobalDownloadManagerCatalogDelete.kt
• app/src/main/java/moe/ouom/neriplayer/core/player/download/AudioDownloadManagerFacadeLifecycle.kt

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

初始化下载管理器时，仪器测试运行期间会跳过默认网络回调注册。新增测试断言网络恢复监视器未注册。删除歌曲时，成功和失败计数仍逐次更新；进度仅在首次、每 32 次及最后一次尝试时发布，发布过程由锁串行化。

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 37cfe

No concrete merge-blocking issue is established for the network-callback guard or deletion-progress change. Merge after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 37cfe

The changes affect test-time network recovery and the frequency of visible deletion updates. The reviewed paths do not show a new production bypass or a change to when deletion is considered complete, though coverage is incomplete.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The identified conditional bypass is confined to download network-recovery callback registration when the app process has been marked as an instrumentation runtime. No attacker-controlled production activation path was established in the reviewed callers.

Trust Boundaries and Controls

• observed — The initialization guard is evaluated after network-policy state is seeded and before callback creation. The observed test runner sets the marker before application creation; ordinary initialization continues to callback registration when the marker is inactive.

Resilience and Maintainability Implications

• observed — Deletion does not use throttled intermediate counts to declare completion. It verifies references, settles catalog state, and publishes a terminal success or failure phase; interruption paths publish failure and schedule reconciliation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	标题准确概括了两个主要变更：跳过测试运行时的网络恢复注册，以及节流删除进度发布。
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}