Skip to content

test(download): allow CI scheduling headroom for provider delete timing - #441

Merged
cwuom merged 1 commit into
masterfrom
intention/fix-ci-delete-timing-flake
Sep 26, 2026
Merged

cwuom merged 1 commit into
masterfrom
intention/fix-ci-delete-timing-flake

Conversation

@cwuom

@cwuom cwuom commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

The Android instrumented deletion test intermittently fails on CI emulator scheduling: a run reported first progress at 1002 ms against an 800 ms limit, while the deletion assertions continued to pass.

Raise the test-only first-progress budget to 2 seconds and completion budget to 5 seconds, with explicit limits in failure messages. The test still requires all 256 provider files to be physically deleted, no unconfirmed deletes, and bounded parallelism. Existing unit coverage checks that progress is reported after the small first batch.

Validation:

  • :app:testDebugUnitTest --tests 'moe.ouom.neriplayer.core.download.storage.ManagedDownloadReferenceDeleteExecutorTest': 23 passed.
  • :app:connectedDebugAndroidTest filtered to ManagedDownloadDocumentsProviderDeleteTest: 2 passed; both tests passed in five additional local emulator runs.
  • git diff --check: passed.

The local emulator was API 37; the upstream API 35 CI run remains to be observed.

将 Android 仪器测试的首次删除进度超时预算从 800 ms 调整为 2 秒,将删除完成预算从 1,500 ms 调整为 5 秒。失败信息会显示对应的超时上限。

测试仍要求删除全部 256 个 provider 文件,不出现未确认删除,并限制并行度。单元测试检查小批次删除后会报告进度。

已提供的测试结果:23 项单元测试通过,2 项筛选后的仪器测试通过;另有 5 次本地模拟器运行成功。上游 API 35 CI 结果尚未确认。

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: cwuom/NeriPlayer/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 0ae41cbd-ff2d-4daf-8cef-9d6a2e2c6062

📥 Commits

Reviewing files that changed from the base of the PR and between 58bc65f and bade44b.

📒 Files selected for processing (1)
  • app/src/androidTest/java/moe/ouom/neriplayer/core/download/ManagedDownloadDocumentsProviderDeleteTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

删除测试新增首次进度和删除完成的超时常量,分别设为 2,000 毫秒和 5,000 毫秒。对应断言改用这些常量,替代原先的 800 毫秒和 1,500 毫秒上限。

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to bade4

The Android test allows more CI scheduling time while still checking deletion results and bounded parallelism. No actionable merge risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了主要变更:为下载提供程序删除测试增加 CI 调度余量。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cwuom
cwuom merged commit 9bb6512 into master Sep 26, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant