test(download): allow CI scheduling headroom for provider delete timing - #441
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: cwuom/NeriPlayer/.coderabbit.yaml Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthrough删除测试新增首次进度和删除完成的超时常量,分别设为 2,000 毫秒和 5,000 毫秒。对应断言改用这些常量,替代原先的 800 毫秒和 1,500 毫秒上限。 Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The Android test allows more CI scheduling time while still checking deletion results and bounded parallelism. No actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Android instrumented deletion test intermittently fails on CI emulator scheduling: a run reported first progress at 1002 ms against an 800 ms limit, while the deletion assertions continued to pass.
Raise the test-only first-progress budget to 2 seconds and completion budget to 5 seconds, with explicit limits in failure messages. The test still requires all 256 provider files to be physically deleted, no unconfirmed deletes, and bounded parallelism. Existing unit coverage checks that progress is reported after the small first batch.
Validation:
:app:testDebugUnitTest --tests 'moe.ouom.neriplayer.core.download.storage.ManagedDownloadReferenceDeleteExecutorTest': 23 passed.:app:connectedDebugAndroidTestfiltered toManagedDownloadDocumentsProviderDeleteTest: 2 passed; both tests passed in five additional local emulator runs.git diff --check: passed.The local emulator was API 37; the upstream API 35 CI run remains to be observed.
将 Android 仪器测试的首次删除进度超时预算从 800 ms 调整为 2 秒,将删除完成预算从 1,500 ms 调整为 5 秒。失败信息会显示对应的超时上限。
测试仍要求删除全部 256 个 provider 文件,不出现未确认删除,并限制并行度。单元测试检查小批次删除后会报告进度。
已提供的测试结果:23 项单元测试通过,2 项筛选后的仪器测试通过;另有 5 次本地模拟器运行成功。上游 API 35 CI 结果尚未确认。