An anonymous BrowserSession borrows a browser with no login - #323
Merged
Conversation
czpython
force-pushed
the
anonymous-browser-borrow
branch
from
August 24, 2026 13:04
726e568 to
d984151
Compare
czpython
force-pushed
the
anonymous-browser-borrow
branch
from
August 24, 2026 13:07
d984151 to
cb62105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserSession(site=..., anonymous=True)declares a session that needs no login. A borrow skips the ready check and opens the browser on a blank profile — the launcher already reads a version-zerostate.meta.jsonas "nothing to unpack", so the borrow uploads only that. The seeding logic is now one function,seed_state, shared by the borrow and the login window.The row still materializes on first borrow with the new
anonymousstatus, andmark_usedkeeps recording, so the pane shows real last-used data. The pane shows the session as "Anonymous — no login needed" with no sign-in action. The login-window and state-import routes refuse an anonymous session with a 409 that says why.anonymous=Truewithpersist=Trueraises at class definition — there is no state to write back.BrowserSessionSignedOutErrorinside an anonymous borrow still fails the run, but the signed-out subscriber leaves the row anonymous instead of flipping it to stale.ENG-876