Skip to content

🛡️ Sentinel: [improvement] Neutralize additional CSV formula injection triggers - #231

Closed
d0linger wants to merge 1 commit into
mainfrom
sentinel/csv-injection-triggers-7359853241613566842
Closed

d0linger wants to merge 1 commit into
mainfrom
sentinel/csv-injection-triggers-7359853241613566842

Conversation

@d0linger

Copy link
Copy Markdown
Owner

🛡️ Sentinel Security PR

  • Severity: MEDIUM (Defense-in-depth / Formula Injection Prevention)
  • Vulnerability: Unsanitized CSV export values starting with % or | could trigger formula execution or command execution in certain spreadsheet engines (e.g. Excel or LibreOffice Calc) when opened by users.
  • Impact: An attacker who enters names or notes starting with % or | could execute formula functions or pipe operations if exported CSV files are opened in spreadsheets that evaluate those characters as formula/command triggers.
  • Fix: Enhanced csvSafe in internal/server/export.go to include %, |, \t, and \r alongside =, +, -, and @ in the switch statement that prefixes input with a single quote (').
  • Verification: Added test cases in internal/server/cookie_test.go (TestCSVSafe) verifying that strings starting with % and | are properly sanitized with a single quote. Ran go test ./... successfully.

PR created automatically by Jules for task 7359853241613566842 started by @d0linger

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@d0linger

Copy link
Copy Markdown
Owner Author

Superseded by #239

@d0linger d0linger closed this Oct 15, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded by #239

Understood. Acknowledging that this PR has been superseded by #239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant