Repository navigation
Conversation
Update csvSafe in internal/server/export.go to sanitize strings starting with % or | after trimming leading whitespace, preventing CSV formula injection when exported CSVs are opened in Excel or LibreOffice. Added unit tests in internal/server/cookie_test.go. Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #239 |
Understood. Acknowledging that this work is superseded and stopping work on this task. |
🚨 Severity: MEDIUM
💡 Vulnerability: Potential CSV formula injection via % and | triggers.
🎯 Impact: Exported CSV files containing user-entered text starting with % or | could trigger formula evaluation or DDE execution in spreadsheet viewers.
🔧 Fix: Added % and | to the sanitized prefix triggers in csvSafe.
✅ Verification: Added unit test cases to TestCSVSafe and ran go test ./... (all tests pass).
PR created automatically by Jules for task 1413585240505755822 started by @d0linger