Repository navigation
Conversation
Enforce input length limits on form parameters in handleFuelAdjustmentSave (effective_from <= 50 characters, amount_per_h <= 32 characters) using s.tooLong before parsing to prevent CPU/memory exhaustion (DoS) attacks. Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #239 |
effective_fromandamount_per_hform parameters inhandleFuelAdjustmentSave.s.tooLongvalidation upfront foreffective_from(capped at 50 chars) andamount_per_h(capped atmaxDecimalLen/ 32 chars) inhandleFuelAdjustmentSave.internal/server/input_limits_test.goand verified all unit tests pass withgo test ./....PR created automatically by Jules for task 17705360170889894683 started by @d0linger