Skip to content

🛡️ Sentinel: [MEDIUM] Add input limits to accounting export profile selection - #241

Draft
d0linger wants to merge 2 commits into
mainfrom
jules-16952842325120142018-2d88edfd
Draft

d0linger wants to merge 2 commits into
mainfrom
jules-16952842325120142018-2d88edfd

Conversation

@d0linger

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
💡 Vulnerability: Missing input list length and string length validation on r.PostForm["columns"] in handleAccountingProfileSave.
🎯 Impact: Oversized POST payload submissions could cause CPU and memory resource exhaustion (DoS) during form parsing, string joining, and column splitting operations on the administrative accounting profile configuration route /rechnungsjournal/profile.
🔧 Fix: Capped len(r.PostForm["columns"]) against maxFormListLen before strings.Join and validated joined columns against maxNoteLen via s.tooLong in internal/server/journal.go.
✅ Verification: Added unit tests in internal/server/input_limits_test.go and integration tests in internal/server/journal_integration_test.go. Verified with go test ./....


PR created automatically by Jules for task 16952842325120142018 started by @d0linger

… columns

Add slice length (`maxFormListLen`) and string length (`maxNoteLen`) validation to `handleAccountingProfileSave` in `internal/server/journal.go` to prevent CPU and memory resource exhaustion DoS attacks from oversized payloads. Added corresponding unit and integration tests.

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

… columns

Add slice length (`maxFormListLen`) and string length (`maxNoteLen`) validation to `handleAccountingProfileSave` in `internal/server/journal.go` to prevent CPU and memory resource exhaustion DoS attacks from oversized payloads. Added corresponding unit and integration tests.

Co-authored-by: d0linger <61334677+d0linger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant